6019c78cc9
Complete excercise 8
2025-02-26 09:55:45 +09:00
478676904f
Complete 7
2025-02-22 10:53:29 +09:00
f8b292fa9f
Complete 6
2025-02-22 10:46:02 +09:00
9aadd94685
Completed 1-5
2025-02-22 10:40:23 +09:00
c415382137
Completed 1-4
2025-02-22 10:23:40 +09:00
d4421b055f
Merge pull request #524 from RedViperPT/issue_javascript-exercises_05_sumAll
...
05_sumAll: Fix tests to require correct range summation
2025-02-11 16:03:10 -07:00
b92866af31
Update the tests for the solutions
2025-02-11 22:55:05 +00:00
b025e48055
Improve testing to ensure solution matches expected behaviour
2025-02-11 22:36:53 +00:00
59b5fc725e
Merge pull request #518 from MaoShizhong/contributing-md
...
Add repo-specific CONTRIBUTING.md
2025-02-10 20:47:41 -07:00
45d06e12ff
Merge pull request #522 from MaoShizhong/repeat-string-test
...
02_repeatString: Replace regex test with built-in repeat method
2025-02-10 20:04:47 -07:00
ace1d6eb4d
Merge pull request #523 from MaoShizhong/repeat-string-builtin
...
02_repeatString: Add test preventing use of `String.prototype.repeat`
2025-02-10 20:03:00 -07:00
098f3f4733
Add important reminder about approved issue before PR
2025-02-04 16:08:11 +00:00
b4be1d8752
Combine separate instruction sentence with instruction list
2025-02-04 16:05:32 +00:00
5ea6746a8d
Add test preventing use of built-in String repeat method
2025-02-04 04:08:26 +00:00
c5d806b88c
Replace regex test with String.prototype.repeat test
...
Easier for learners to understand test and does not require extra explanation of regex
2025-02-04 03:51:30 +00:00
15d4dd07e7
Tidy up comment style
2025-02-04 03:48:41 +00:00
fd555e354c
Merge pull request #521 from bhagyeshsp/patch-3
...
02_repeatString/solution - Line-32, replace "odin" with "hey"
2025-02-03 15:35:26 -07:00
e10d52cbc9
Merge pull request #505 from bhagyeshsp/patch-1
...
02_repeatString - Line-32, replace "odin" with "hey"
2025-02-03 15:35:07 -07:00
598ab5c937
02_repeatString/solution - Line-32, replace "odin" with "hey"
...
As asked by @JoshDevHub in a discussion of a related PR, I made a similar change to this solution. In the earlier code, the comment description mentioned "hey" as a sample string but the code had "odin" string. This update addresses that tiny gap between sample comments and related code.
More on: https://github.com/TheOdinProject/javascript-exercises/pull/505#pullrequestreview-2588692590
2025-02-03 09:58:47 +05:30
0da5ad23ef
Merge pull request #506 from bhagyeshsp/patch-2
...
Update 06_leapYears README.md with a reference
2025-02-02 17:13:50 -07:00
39169ed45d
Use lazy numbering for ordered list
2025-01-29 15:07:27 +00:00
bc1a836bbb
Use repo-specific contributing guide link
2025-01-29 14:59:32 +00:00
7ef188212e
Remove 'Adding New Exercises' section from general README.md
2025-01-29 14:58:38 +00:00
58df2c0495
Add contributing guide file
2025-01-29 14:58:19 +00:00
305ad2dfc8
Update 06_leapYears README.md with a reference
...
I updated the README with an external link outlining the nested rules for leap years. The present problem statement, borrowed from Chris Pine, does not clearly state these rules, which is indeed confusing.
To scaffold the learner's journey, it would be useful to add a reference that walks them through the leap year rules with examples. It difficult to stick to the practice exercise if the learner has to shoot in the dark without knowing the exact rules of the game.
2024-11-16 22:26:40 +05:30
2861e62954
Javascript-exercises: 02_repeatString - Fix code on line 32
...
The original code had "hey" as the seed string value and hence the comment on line-29 mentions "hey". But the last commit on the code changed "hey" to "odin".
We can either change instances of comment or the code. I propose changing the code instance from "odin" to "hey" for consistency.
2024-11-13 19:37:26 +05:30
203fd76a54
Merge pull request #501 from o1Suleyman/patch-2
...
Whitespace and capitalization correction
2024-10-30 16:18:23 +00:00
406b4c411e
Whitespace and capitalization correction
2024-10-26 13:22:50 +04:00
e51671ec4f
Calculator Factorial: Remove redundant guard clause ( #499 )
2024-10-18 19:40:42 +01:00
a12f3116fd
08_calculator:Add more test cases for subtract and power ( #494 )
2024-09-23 18:09:04 +01:00
7ff69d817d
Refactor issue markdowm to YAML templates ( #491 )
2024-09-04 21:16:13 +01:00
29dd5a4a2e
feat(repeatString): enforce manual implementation via loops ( #460 )
...
Intent is to practise using loops rather than wrap the built-in `repeat` String method.
2024-08-10 18:00:39 +01:00
0c5480d00e
sumAll: Unify tests between solution and non-solution spec file ( #488 )
2024-07-17 14:02:56 +01:00
3c636bebee
Leap Years: Use more appropriate solution ( #483 )
...
Replacement solution is closer to what most learners might think of due to the instructions' hints, and concepts they'll have been reasonably exposed to so far in the curriculum.
The original solution has been a curveball for quite a few people.
Co-authored-by: Josh Veneziano <jveneziano@proton.me >
2024-06-27 12:25:01 +01:00
435b88bf19
Merge pull request #481 from TheOdinProject/dependabot/npm_and_yarn/braces-3.0.3
...
Bump braces from 3.0.2 to 3.0.3
2024-06-11 15:16:57 -04:00
6e3d7d2d19
Bump braces from 3.0.2 to 3.0.3
...
Bumps [braces](https://github.com/micromatch/braces ) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
---
updated-dependencies:
- dependency-name: braces
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-11 18:43:45 +00:00
82712dbac1
Merge pull request #478 from pixie-cheeks/check_node_ver
...
Project Root: Add minimum npm & node version requirements
2024-06-11 14:43:09 -04:00
c79a878fce
Add minimum npm & node version requirements
...
This change will prevent any old node or npm version from installing any
packages. With this, npm will throw an error and exit immediately.
This is to prevent the accidental use of unsupported versions which
might cause some issues that are hard to pin-point.
2024-06-04 15:43:52 +05:30
2154dcec4a
Changed number to integer in sumAll ( #477 )
2024-06-01 12:43:35 +01:00
312bd8a1d9
05_sumAll: Update README.md ( #475 )
...
* Change 'integers' to 'positive integers' in question statement
* requested changes
* requested changes
* requested changes
2024-05-25 13:36:54 +01:00
d67e7a3ecb
03_reverseString - update punctuation test case to include comma ( #467 )
2024-05-06 19:40:50 +01:00
097a73634f
Merge pull request #465 from JoshDevHub/change_style_of_notes
...
Change styling of notes for avoiding PRs and error messages
2024-05-04 14:12:04 -06:00
6f9080c3db
Change styling of notes for avoiding PRs and error messages
2024-05-04 13:06:04 -07:00
1695abe9d4
Exercise 12: Provide alternative solution ( #459 )
...
* feat(12): improve solution by making it more cleaner
* refactor(12): rename `array` to `people`
* feat(12): improve explanation of `??=`
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com >
* feat(12): include both solutions
* feat(12): hint to use various array methods
* refactor(12): add semicolon
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com >
* feat(12): use block comments instead of line for readability
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com >
* refactor(12): remove unnecessary comment
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com >
---------
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com >
2024-05-03 16:30:56 +01:00
45a5ced879
Improve README verbiage ( #453 )
...
This is sort of a grab-bag of things that I found while reading the README.
Each change is fairly small so it seemed best to combine them under one commit.
* Add link to The Odin Project home page in 1st paragraph.
* Remove a few contractions. (Contractions are not used consitently here,
so it was easier/better to just remove the few that popped up.)
* Fix some awkward phrasing.
2024-05-03 02:16:06 +01:00
930673d9c8
feat(08): remove recursive solution ( #457 )
...
Not appropriate to expose learners to at this point in the curriculum
2024-05-03 02:13:38 +01:00
1afbcf8644
feat(04): use const instead of var in solution ( #456 )
2024-05-03 02:12:28 +01:00
1c322ddb47
Merge pull request #420 from kumang-subba/repeatstring_test_alternate_strings
...
added alternate repeatString test strings
2024-04-20 08:14:28 -04:00
9a5cdecf5b
Update 02_repeatString/solution/repeatString-solution.spec.js
...
Co-authored-by: Nikita Revenco <154856872+nikitarevenco@users.noreply.github.com >
2024-03-24 07:09:52 +02:00
8209109149
Merge pull request #436 from TheOdinProject/plopGenerator
...
Replace generator-exercise with plop generator
2024-03-03 13:33:51 -05:00
Thuan Bui