As asked by @JoshDevHub in a discussion of a related PR, I made a similar change to this solution. In the earlier code, the comment description mentioned "hey" as a sample string but the code had "odin" string. This update addresses that tiny gap between sample comments and related code.
More on: https://github.com/TheOdinProject/javascript-exercises/pull/505#pullrequestreview-2588692590
I updated the README with an external link outlining the nested rules for leap years. The present problem statement, borrowed from Chris Pine, does not clearly state these rules, which is indeed confusing.
To scaffold the learner's journey, it would be useful to add a reference that walks them through the leap year rules with examples. It difficult to stick to the practice exercise if the learner has to shoot in the dark without knowing the exact rules of the game.
The original code had "hey" as the seed string value and hence the comment on line-29 mentions "hey". But the last commit on the code changed "hey" to "odin".
We can either change instances of comment or the code. I propose changing the code instance from "odin" to "hey" for consistency.
Replacement solution is closer to what most learners might think of due to the instructions' hints, and concepts they'll have been reasonably exposed to so far in the curriculum.
The original solution has been a curveball for quite a few people.
Co-authored-by: Josh Veneziano <jveneziano@proton.me>
This change will prevent any old node or npm version from installing any
packages. With this, npm will throw an error and exit immediately.
This is to prevent the accidental use of unsupported versions which
might cause some issues that are hard to pin-point.
This is sort of a grab-bag of things that I found while reading the README.
Each change is fairly small so it seemed best to combine them under one commit.
* Add link to The Odin Project home page in 1st paragraph.
* Remove a few contractions. (Contractions are not used consitently here,
so it was easier/better to just remove the few that popped up.)
* Fix some awkward phrasing.
Adapted the non-regex solution provided in the solutions branch (which
was not brought over to the main branch's solution file) to pass the
current test suite.
Cleaned formatting of comments and reworded for clarity.
fix ambiguity in test description , old was 'finds the person with the
greatest age if someone is still living.'
remove redundant test that checks for 'finds the person with the
greatest age if the OLDEST is still living' since both this and the
above test for ability to check if there is no death year field.
MaoShizhong