10h30/genesis-simple-sidebars
1
0
Fork 0
mirror of https://github.com/10h30/genesis-simple-sidebars.git synced 2026-06-05 15:08:34 +09:00
Code Issues Packages Projects Releases Wiki Activity

Only allow alphanumeric characters in IDs. fixes #10.

Browse Source
This commit is contained in:
Nathan Rice
2017-03-01 19:48:53 -05:00
parent 4e5bfa7caf
commit 357bc65a70
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
includes/class-genesis-simple-sidebars-admin.php
+9 -11
View File
@@ -225,19 +225,22 @@ class Genesis_Simple_Sidebars_Admin extends Genesis_Admin_Basic {
// Change empty or numeric IDs to the name, lowercased and separated by dashes.
if ( empty( $args['id'] ) || is_numeric( $args['id'] ) ) {
$args['id'] = sanitize_title_with_dashes( $args['name'] );
$args['id'] = $args['name'];
}
// Strip all but alphanumeric, sanitize with dashes.
$id = preg_replace( "/[^a-zA-Z0-9 -]+/", "", sanitize_title_with_dashes( $args['id'] ) );
$db = (array) get_option( $this->settings_field );
$new = array(
sanitize_title_with_dashes( $args['id'] ) => array(
$id => array(
'name' => esc_html( $args['name'] ),
'description' => esc_html( $args['description'] )
)
),
);
if ( array_key_exists( $args['id'], $db ) ) {
if ( array_key_exists( $id, $db ) ) {
wp_die( $this->error( 2 ) );
exit;
}
@@ -266,15 +269,10 @@ class Genesis_Simple_Sidebars_Admin extends Genesis_Admin_Basic {
// nonce verification
check_admin_referer( 'simple-sidebars-action_edit-sidebar' );
// WP changes a numeric sidebar id to sidebar-id which makes it inaccessible to the user
if ( is_numeric( $args['id'] ) ) {
$args['id'] = sanitize_title_with_dashes( $args['name'] );
}
$db = (array) get_option( $this->settings_field );
$new = array(
sanitize_title_with_dashes( $args['id'] ) => array(
'name' => esc_html( $args['name'] ),
$args['id'] => array(
'name' => esc_html( $args['name'] ),
'description' => esc_html( $args['description'] )
)
);