fix hidden field data

if the setting was a URL we had inconsistent behavior.
This commit is contained in:
Robin Cornett
2015-04-10 09:32:57 -04:00
parent a422bda814
commit 41c51f337e
2 changed files with 7 additions and 4 deletions
@@ -217,6 +217,7 @@ class Display_Featured_Image_Genesis_Settings {
public function set_default_image() {
$large = Display_Featured_Image_Genesis_Common::minimum_backstretch_width();
$id = '';
if ( ! empty( $this->displaysetting['default'] ) ) {
$id = $this->displaysetting['default'];
@@ -228,7 +229,7 @@ class Display_Featured_Image_Genesis_Settings {
echo '<img src="' . esc_url( $preview[0] ) . '" />';
echo '</div>';
}
echo '<input type="hidden" class="upload_image_url" id="displayfeaturedimagegenesis[default]" name="displayfeaturedimagegenesis[default]" value="' . absint( $this->displaysetting['default'] ) . '" />';
echo '<input type="hidden" class="upload_image_url" id="displayfeaturedimagegenesis[default]" name="displayfeaturedimagegenesis[default]" value="' . absint( $id ) . '" />';
echo '<input type="button" class="upload_default_image button-secondary" value="' . __( 'Select Image', 'display-featured-image-genesis' ) . '" />';
if ( ! empty( $this->displaysetting['default'] ) ) {
echo '<input type="button" class="delete_image button-secondary" value="' . __( 'Delete Image', 'display-featured-image-genesis' ) . '" />';
@@ -309,7 +310,7 @@ class Display_Featured_Image_Genesis_Settings {
$post_type = $post->name;
if ( empty( $this->displaysetting['post_type'][$post_type] ) ) {
$this->displaysetting['post_type'][$post_type] = '';
$this->displaysetting['post_type'][$post_type] = $id = '';
}
echo '<div>';
echo '<h4>' . $post->label . '</h4>';
@@ -323,7 +324,8 @@ class Display_Featured_Image_Genesis_Settings {
echo '<img src="' . esc_url( $preview[0] ) . '" />';
echo '</div>';
}
echo '<input type="hidden" class="upload_image_url" id="displayfeaturedimagegenesis[post_type][' . $post_type . ']" name="displayfeaturedimagegenesis[post_type][' . $post_type . ']" value="' . absint( $this->displaysetting['post_type'][$post_type] ) . '" />';
echo '<input type="hidden" class="upload_image_url" id="displayfeaturedimagegenesis[post_type][' . $post_type . ']" name="displayfeaturedimagegenesis[post_type][' . $post_type . ']" value="' . absint( $id ) . '" />';
echo '<input type="button" class="upload_default_image button-secondary" value="' . __( 'Select Image', 'display-featured-image-genesis' ) . '" />';
if ( ! empty( $this->displaysetting['post_type'][$post_type] ) ) {
echo '<input type="button" class="delete_image button-secondary" value="' . __( 'Delete Image', 'display-featured-image-genesis' ) . '" />';
@@ -39,6 +39,7 @@ class Display_Featured_Image_Genesis_Taxonomies {
$t_id = $term->term_id;
$displaysetting = get_option( "displayfeaturedimagegenesis_$t_id" );
$medium = get_option( 'medium_size_w' );
$id = '';
echo '<tr class="form-field term-image-wrap">';
echo '<th scope="row" valign="top"><label for="displayfeaturedimagegenesis[term_image]">' . __( 'Featured Image', 'display-featured-image-genesis' ) . '</label></th>';
@@ -53,7 +54,7 @@ class Display_Featured_Image_Genesis_Taxonomies {
echo '<img src="' . esc_url( $preview[0] ) . '" width="300" />';
echo '</div>';
}
echo '<input type="hidden" class="upload_image_url" id="default_image_url" name="displayfeaturedimagegenesis[term_image]" value="' . esc_url( $displaysetting['term_image'] ) . '" />';
echo '<input type="hidden" class="upload_image_url" id="default_image_url" name="displayfeaturedimagegenesis[term_image]" value="' . absint( $id ) . '" />';
echo '<input id="upload_default_image" type="button" class="upload_default_image button-secondary" value="' . __( 'Select Image', 'display-featured-image-genesis' ) . '" />';
if ( ! empty( $displaysetting['term_image'] ) ) {
echo '<input type="button" class="delete_image button-secondary" value="' . __( 'Delete Image', 'display-featured-image-genesis' ) . '" />';