From dc281c2c0d64eb3518adffaa7aaba22b2b51a874 Mon Sep 17 00:00:00 2001
From: nikitasinelnikov <nsinelnikov.work@gmail.com>
Date: Mon, 10 Aug 2020 11:40:30 +0300
Subject: [PATCH] - code review;

---
 includes/core/class-fields.php | 8 ++++++--
 readme.txt                     | 2 ++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/includes/core/class-fields.php b/includes/core/class-fields.php
index dd36975a..820afa0d 100644
--- a/includes/core/class-fields.php
+++ b/includes/core/class-fields.php
@@ -379,7 +379,9 @@ if ( ! class_exists( 'um\core\Fields' ) ) {
 		 */
 		function field_error( $text, $force_show = false ) {
 
-			if( empty( $text ) ) return;
+			if ( empty( $text ) ) {
+				return '';
+			}
 
 			if ( $force_show ) {
 				$output = '<div class="um-field-error"><span class="um-field-arrow"><i class="um-faicon-caret-up"></i></span>' . esc_attr( $text ) . '</div>';
@@ -411,7 +413,9 @@ if ( ! class_exists( 'um\core\Fields' ) ) {
 		 */
 		function field_notice( $text, $force_show = false ) {
 
-			if( empty( $text ) ) return;
+			if ( empty( $text ) ) {
+				return '';
+			}
 
 			if ( $force_show ) {
 				$output = '<div class="um-field-notice"><span class="um-field-arrow"><i class="um-faicon-caret-up"></i></span>' . esc_attr( $text ) . '</div>';
diff --git a/readme.txt b/readme.txt
index ebf73591..54b51b65 100644
--- a/readme.txt
+++ b/readme.txt
@@ -166,6 +166,7 @@ The plugin works with popular caching plugins by automatically excluding Ultimat
   - Fixed member directory roles in query (the case when selected some roles, but current user can see another only)
   - Fixed member directory sorting
   - Fixed member directory list dropdown init after changing view type
+  - Fixed member directory admin filtering by the 'user_registered' field
   - Fixed validation when using HTML in textarea
   - Fixed cleaning user old uploads
   - Fixed conditional logic for file/image-type fields
@@ -174,6 +175,7 @@ The plugin works with popular caching plugins by automatically excluding Ultimat
   - Fixed getting extension updates on multisites
   - Fixed the 'wp_authenticate_user' filter's variables (changed username string to WP_User object)
   - Fixed SEO link canonical for the profile page
+  - Fixed displaying error & notice when the text is empty
   - Deprecated JS event 'um_before_modal_removed', use wp.hooks action 'um_before_modal_removed' instead
 
 = 2.1.6: June 1, 2020 =