From 820ef35104a74e93a4ebfec80c3679e1c0bebd95 Mon Sep 17 00:00:00 2001
From: Mykyta Synelnikov <nsinelnikov.work@gmail.com>
Date: Tue, 15 Apr 2025 14:54:44 +0300
Subject: [PATCH] Fix user meta key for registration progress handling

Updated the user meta key from `um_registration_in_progress` to `_um_registration_in_progress` across multiple files for consistency and proper functionality. This change ensures accurate checking and handling of users in the registration process.
---
 includes/common/actions/class-users.php | 6 +++---
 includes/common/class-users.php         | 2 +-
 includes/core/um-actions-register.php   | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/includes/common/actions/class-users.php b/includes/common/actions/class-users.php
index d034f3cf..e3309b6a 100644
--- a/includes/common/actions/class-users.php
+++ b/includes/common/actions/class-users.php
@@ -62,7 +62,7 @@ if ( ! class_exists( 'um\common\actions\Users' ) ) {
 
 		/**
 		 * Perform batch checking for users based on specific conditions.
-		 * Ignore users with `um_registration_in_progress` that can be in the process of the registration.
+		 * Ignore users with `_um_registration_in_progress` that can be in the process of the registration.
 		 * Get users with empty `account_status` meta.
 		 *
 		 * @param int $page The current page number.
@@ -79,11 +79,11 @@ if ( ! class_exists( 'um\common\actions\Users' ) ) {
 						array(
 							'relation' => 'OR',
 							array(
-								'key'     => 'um_registration_in_progress',
+								'key'     => '_um_registration_in_progress',
 								'compare' => 'NOT EXISTS',
 							),
 							array(
-								'key'     => 'um_registration_in_progress',
+								'key'     => '_um_registration_in_progress',
 								'value'   => '1',
 								'compare' => '!=',
 							),
diff --git a/includes/common/class-users.php b/includes/common/class-users.php
index f5d1f933..392c29d2 100644
--- a/includes/common/class-users.php
+++ b/includes/common/class-users.php
@@ -843,7 +843,7 @@ class Users {
 			"SELECT COUNT(u.ID)
 			FROM {$wpdb->users} u
 			LEFT JOIN {$wpdb->usermeta} um ON u.ID = um.user_id AND um.meta_key = 'account_status'
-			LEFT JOIN {$wpdb->usermeta} um2 ON u.ID = um2.user_id AND um2.meta_key = 'um_registration_in_progress'
+			LEFT JOIN {$wpdb->usermeta} um2 ON u.ID = um2.user_id AND um2.meta_key = '_um_registration_in_progress'
 			WHERE ( um.meta_value IS NULL OR um.meta_value = '' ) AND
 				  um2.meta_value IS NULL OR um2.meta_value != '1'"
 		);
diff --git a/includes/core/um-actions-register.php b/includes/core/um-actions-register.php
index 2459d56c..b30d43a9 100644
--- a/includes/core/um-actions-register.php
+++ b/includes/core/um-actions-register.php
@@ -169,7 +169,7 @@ function um_check_user_status( $user_id, $args, $form_data = null ) {
 	 */
 	do_action( "um_post_registration_{$registration_status}_hook", $user_id, $args, $form_data );
 
-	delete_user_meta( $user_id, 'um_registration_in_progress' ); // Status is set. We can delete this marker.
+	delete_user_meta( $user_id, '_um_registration_in_progress' ); // Status is set. We can delete this marker.
 
 	if ( is_null( $form_data ) || is_admin() ) {
 		return;
@@ -507,7 +507,7 @@ function um_submit_form_register( $args, $form_data ) {
 		'meta_input' => array(
 			// It's used to ignore users who cannot finish the registration process in the scheduled tasks
 			// to set 'approved' status to the users without `account_status` meta.
-			'um_registration_in_progress' => true,
+			'_um_registration_in_progress' => true,
 		),
 	);