10h30/odin-javascript-exercises
1
0
Fork 0
mirror of https://github.com/10h30/odin-javascript-exercises.git synced 2026-06-05 15:09:09 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #522 from MaoShizhong/repeat-string-test

Browse Source 
02_repeatString: Replace regex test with built-in repeat method
This commit is contained in:
Josh Smith
2025-02-10 20:04:47 -07:00
committed by GitHub
parent ace1d6eb4d c5d806b88c
commit 45d06e12ff
2 changed files with 19 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
02_repeatString/repeatString.spec.js
+10 -12
View File
@@ -24,19 +24,17 @@ describe('repeatString', () => {
expect(repeatString('goodbye', -1)).toEqual('ERROR'); expect(repeatString('goodbye', -1)).toEqual('ERROR');
}); });
test.skip('repeats the string a random amount of times', function () { test.skip('repeats the string a random amount of times', function () {
/*The number is generated by using Math.random to get a value from between /* The number is generated by using Math.random to get a value from between
0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it 0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it
equals a number between 0 to 999 (this number will change everytime you run equals a number between 0 to 999 (this number will change everytime you run
the test).*/ the test).
// DO NOT use Math.floor(Math.random() * 1000) in your code, DO NOT use Math.floor(Math.random() * 1000) in your code,
// this test generates a random number, then passes it into your code with a function parameter. this test generates a random number, then passes it into your code with a function parameter.
// If this doesn't make sense, you should go read about functions here: https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3 If this doesn't make sense, you should go read about functions here:
const number = Math.floor(Math.random() * 1000) https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3 */
/*The .match(/((hey))/g).length is a regex that will count the number of heys const number = Math.floor(Math.random() * 1000);
in the result, which if your function works correctly will equal the number that expect(repeatString('hey', number)).toBe('hey'.repeat(number));
was randomly generated. */
expect(repeatString('hey', number).match(/((hey))/g).length).toEqual(number);
}); });
test.skip('works with blank strings', () => { test.skip('works with blank strings', () => {
expect(repeatString('', 10)).toEqual(''); expect(repeatString('', 10)).toEqual('');
02_repeatString/solution/repeatString-solution.spec.js
+9 -13
View File
@@ -24,21 +24,17 @@ describe('repeatString', () => {
expect(repeatString('goodbye', -1)).toEqual('ERROR'); expect(repeatString('goodbye', -1)).toEqual('ERROR');
}); });
test('repeats the string a random amount of times', function () { test('repeats the string a random amount of times', function () {
/*The number is generated by using Math.random to get a value from between /* The number is generated by using Math.random to get a value from between
0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it 0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it
equals a number between 0 to 999 (this number will change everytime you run equals a number between 0 to 999 (this number will change everytime you run
the test).*/ the test).
// DO NOT use Math.floor(Math.random() * 1000) in your code, DO NOT use Math.floor(Math.random() * 1000) in your code,
// this test generates a random number, then passes it into your code with a function parameter. this test generates a random number, then passes it into your code with a function parameter.
// If this doesn't make sense, you should go read about functions here: https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3 If this doesn't make sense, you should go read about functions here:
https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3 */
const number = Math.floor(Math.random() * 1000); const number = Math.floor(Math.random() * 1000);
/*The .match(/((hey))/g).length is a regex that will count the number of heys expect(repeatString('hey', number)).toBe('hey'.repeat(number));
in the result, which if your function works correctly will equal the number that
was randomly generated. */
expect(repeatString('hey', number).match(/((hey))/g).length).toEqual(
number
);
}); });
test('works with blank strings', () => { test('works with blank strings', () => {
expect(repeatString('', 10)).toEqual(''); expect(repeatString('', 10)).toEqual('');