From a635fd05240350ca7962437628b64d7d511d2e6c Mon Sep 17 00:00:00 2001
From: Robin Cornett <hello@robincornett.com>
Date: Tue, 6 Jan 2015 20:45:37 -0500
Subject: [PATCH] fixed js to handle multiple buttons

needed to set a global variable, apparently
---
 includes/class-displayfeaturedimagegenesis-settings.php | 6 +++---
 includes/js/settings-upload.js                          | 5 +++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/includes/class-displayfeaturedimagegenesis-settings.php b/includes/class-displayfeaturedimagegenesis-settings.php
index 19f9c23..cef11ba 100644
--- a/includes/class-displayfeaturedimagegenesis-settings.php
+++ b/includes/class-displayfeaturedimagegenesis-settings.php
@@ -215,8 +215,8 @@ class Display_Featured_Image_Genesis_Settings {
 			echo '<img src="' . esc_url( $preview[0] ) . '" />';
 			echo '</div>';
 		}
-		echo '<input type="url" class="upload_image_url" id="default_image_url" name="displayfeaturedimagegenesis[default]" value="' . esc_url( $this->displaysetting['default'] ) . '" />';
-		echo '<input id="upload_default_image" type="button" class="upload_default_image button-primary" value="' . __( 'Select Image', 'display-featured-image-genesis' ) . '" />';
+		echo '<input type="url" class="upload_image_url" id="displayfeaturedimagegenesis[default]" name="displayfeaturedimagegenesis[default]" value="' . esc_url( $this->displaysetting['default'] ) . '" />';
+		echo '<input type="button" class="upload_default_image button-primary" value="' . __( 'Select Image', 'display-featured-image-genesis' ) . '" />';
 		echo '<p class="description">' . sprintf(
 			__( 'If you would like to use a default image for the featured image, upload it here. Must be at least %1$s pixels wide.', 'display-featured-image-genesis' ),
 			absint( $item->large + 1 )
@@ -293,7 +293,7 @@ class Display_Featured_Image_Genesis_Settings {
 				echo '</div>';
 			}
 			echo '<input type="url" class="upload_image_url" id="displayfeaturedimagegenesis[post_type][' . $post_type . ']" name="displayfeaturedimagegenesis[post_type][' . $post_type . ']" value="' . esc_url( $this->displaysetting['post_type'][$post_type] ) . '" />';
-			echo '<input id="displayfeaturedimagegenesis[post_type][' . $post_type . ']" type="button" class="upload_default_image button" value="' . __( 'Select Image', 'display-featured-image-genesis' ) . '" />';
+			echo '<input type="button" class="upload_default_image button" value="' . __( 'Select Image', 'display-featured-image-genesis' ) . '" />';
 
 		}
 
diff --git a/includes/js/settings-upload.js b/includes/js/settings-upload.js
index db3708d..ee061a3 100644
--- a/includes/js/settings-upload.js
+++ b/includes/js/settings-upload.js
@@ -1,10 +1,11 @@
 jQuery(document).ready(function($){
 
 	var custom_uploader;
+	var target_input;
 
 	$('.upload_default_image').click(function(e) {
 
-		var target_input = $(this).prev('.upload_image_url');
+		target_input = $(this).prev('.upload_image_url');
 
 		e.preventDefault();
 
@@ -25,8 +26,8 @@ jQuery(document).ready(function($){
 
 		//When a file is selected, grab the URL and set it as the text field's value
 		custom_uploader.on('select', function() {
+
 			attachment = custom_uploader.state().get('selection').first().toJSON();
-			// $('input[name=' + target_input + ']').val(attachment.url);
 			$(target_input).val(attachment.url);
 		});