From 9c906b4426dfa780bc4dcebdb792ee581ffd5d16 Mon Sep 17 00:00:00 2001 From: Robin Cornett Date: Wed, 17 Aug 2016 15:15:50 -0400 Subject: [PATCH] Update term meta updater Conditional not needed as it's only run if the condition is already met. --- ...s-displayfeaturedimagegenesis-settings.php | 21 +++++++------------ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/includes/class-displayfeaturedimagegenesis-settings.php b/includes/class-displayfeaturedimagegenesis-settings.php index cb0b89d..47d00d9 100644 --- a/includes/class-displayfeaturedimagegenesis-settings.php +++ b/includes/class-displayfeaturedimagegenesis-settings.php @@ -412,8 +412,6 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen /** * Default image uploader * - * @return image - * * @since 1.2.1 */ public function set_default_image() { @@ -445,8 +443,6 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen /** * Custom Post Type image uploader * - * @return image - * * @since 2.0.0 */ public function set_cpt_image( $args ) { @@ -659,16 +655,13 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen if ( ! check_admin_referer( 'displayfeaturedimagegenesis_metanonce', 'displayfeaturedimagegenesis_metanonce' ) ) { return; } - $terms = $this->term_option_query; - if ( $terms ) { - foreach ( $terms as $term ) { - $term_id = str_replace( 'displayfeaturedimagegenesis_', '', $term ); - $option = get_option( $term ); - if ( false !== $option ) { - $image_id = (int) displayfeaturedimagegenesis_check_image_id( $option['term_image'] ); - update_term_meta( $term_id, 'displayfeaturedimagegenesis', $image_id ); - delete_option( "displayfeaturedimagegenesis_{$term_id}" ); - } + foreach ( $this->term_option_query as $term ) { + $term_id = str_replace( 'displayfeaturedimagegenesis_', '', $term ); + $option = get_option( $term, false ); + if ( false !== $option ) { + $image_id = (int) displayfeaturedimagegenesis_check_image_id( $option['term_image'] ); + update_term_meta( $term_id, 'displayfeaturedimagegenesis', $image_id ); + delete_option( "displayfeaturedimagegenesis_{$term_id}" ); } } }