From 50443f897436eccde7a6dde67533ff3ca8902ed5 Mon Sep 17 00:00:00 2001
From: Robin Cornett <hello@robincornett.com>
Date: Tue, 26 Apr 2016 11:34:55 -0400
Subject: [PATCH] Fix image preview alt tag

Added the alt to taxonomy and author images. Set the alt to optional.
Cheated and updated strings and abysmal docs on the author class.
---
 ...ass-displayfeaturedimagegenesis-author.php | 22 +++++++++++++++----
 ...ass-displayfeaturedimagegenesis-helper.php |  4 ++--
 ...displayfeaturedimagegenesis-taxonomies.php |  8 +++----
 3 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/includes/class-displayfeaturedimagegenesis-author.php b/includes/class-displayfeaturedimagegenesis-author.php
index f690665..2c115b9 100644
--- a/includes/class-displayfeaturedimagegenesis-author.php
+++ b/includes/class-displayfeaturedimagegenesis-author.php
@@ -11,6 +11,10 @@
 
 class Display_Featured_Image_Genesis_Author extends Display_Featured_Image_Genesis_Helper {
 
+	/**
+	 * The key for the plugin user meta.
+	 * @var string $name
+	 */
 	protected $name;
 
 	/**
@@ -29,6 +33,10 @@ class Display_Featured_Image_Genesis_Author extends Display_Featured_Image_Genes
 		add_action( 'edit_user_profile_update', array( $this, 'save_profile_fields' ) );
 	}
 
+	/**
+	 * Add the featured image row to the user profile.
+	 * @param $user object the user being edited.
+	 */
 	public function do_author_fields( $user ) {
 
 		$id = get_the_author_meta( $this->name, $user->ID );
@@ -36,21 +44,27 @@ class Display_Featured_Image_Genesis_Author extends Display_Featured_Image_Genes
 		echo '<table class="form-table">';
 
 			echo '<tr class="user-featured-image-wrap">';
-				echo '<th scope="row"><label for="' . esc_attr( $this->name ) . '">Featured Image</label></th>';
+				printf( '<th scope="row"><label for="' . esc_attr( $this->name ) . '">%s</label></th>', __( 'Featured Image', 'display-featured-image-genesis' ) );
 
 				echo '<td>';
 				if ( $id ) {
-					echo wp_kses_post( $this->render_image_preview( $id ) );
+					echo wp_kses_post( $this->render_image_preview( $id, $user->display_name ) );
 				}
 
 				$this->render_buttons( $id, $this->name );
-				echo '<p class="description">Upload an image to use as your author page featured image.</p>';
+				printf( '<p class="description">%s</p>', __( 'Upload an image to use as your author page featured image.', 'display-featured-image-genesis' ) );
 				echo '</td>';
 			echo '</tr>';
 
 		echo '</table>';
 	}
 
+	/**
+	 * Update the user meta.
+	 * @param $user_id int The user being updated
+	 *
+	 * @return bool
+	 */
 	public function save_profile_fields( $user_id ) {
 
 		if ( ! current_user_can( 'edit_user', $user_id ) ) {
@@ -97,7 +111,7 @@ class Display_Featured_Image_Genesis_Author extends Display_Featured_Image_Genes
 	 * User profile error message
 	 * @param  var $errors error message depending on what's wrong
 	 * @param  var $update whether or not to update
-	 * @param  var $user   user being updated
+	 * @param  object $user   user being updated
 	 * @return error message
 	 *
 	 * @since 2.3.0
diff --git a/includes/class-displayfeaturedimagegenesis-helper.php b/includes/class-displayfeaturedimagegenesis-helper.php
index 917e8b1..0a992c6 100644
--- a/includes/class-displayfeaturedimagegenesis-helper.php
+++ b/includes/class-displayfeaturedimagegenesis-helper.php
@@ -154,13 +154,13 @@ class Display_Featured_Image_Genesis_Helper {
 	 *
 	 * @since 2.3.0
 	 */
-	public function render_image_preview( $id, $alt ) {
+	public function render_image_preview( $id, $alt = '' ) {
 		if ( empty( $id ) ) {
 			return;
 		}
 
 		$id       = displayfeaturedimagegenesis_check_image_id( $id );
-		$alt_text = sprintf( __( '%s featured image', 'display-featured-image-genesis' ), $alt );
+		$alt_text = sprintf( __( '%s featured image', 'display-featured-image-genesis' ), esc_attr( $alt ) );
 		$preview  = wp_get_attachment_image_src( (int) $id, 'medium' );
 		$image    = sprintf( '<div class="upload_logo_preview"><img src="%s" alt="%s" /></div>', esc_url( $preview[0] ), esc_attr( $alt_text ) );
 		return $image;
diff --git a/includes/class-displayfeaturedimagegenesis-taxonomies.php b/includes/class-displayfeaturedimagegenesis-taxonomies.php
index 5a6ac9e..6504805 100644
--- a/includes/class-displayfeaturedimagegenesis-taxonomies.php
+++ b/includes/class-displayfeaturedimagegenesis-taxonomies.php
@@ -60,10 +60,8 @@ class Display_Featured_Image_Genesis_Taxonomies extends Display_Featured_Image_G
 	}
 
 	/**
-	 * edit term page
-	 * @param  term $term featured image input/display for individual term page
-	 *
-	 * @return preview/uploader       upload/preview featured image for term
+	 * upload/preview featured image for term. edit term page
+	 * @param  object $term featured image input/display for individual term page
 	 *
 	 * @since  2.0.0
 	 */
@@ -79,7 +77,7 @@ class Display_Featured_Image_Genesis_Taxonomies extends Display_Featured_Image_G
 			echo '<td>';
 				$name = 'displayfeaturedimagegenesis[term_image]';
 				if ( $image_id ) {
-					echo wp_kses_post( $this->render_image_preview( $image_id ) );
+					echo wp_kses_post( $this->render_image_preview( $image_id, $term->name ) );
 				}
 				$this->render_buttons( $image_id, $name );
 				echo '<p class="description">';